Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(controller): do not normalize urls when searching for image creds #3110

Merged
merged 1 commit into from
Dec 10, 2024

do not normalize urls when searching for image creds

c152dfe
Select commit
Loading
Failed to load commit list.
Merged

fix(controller): do not normalize urls when searching for image creds #3110

do not normalize urls when searching for image creds
c152dfe
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Dec 10, 2024 in 0s

51.13% (-0.01%) compared to 3a1ee47, passed because coverage increased by 0% when compared to adjusted base (51.13%)

View this Pull Request on Codecov

51.13% (-0.01%) compared to 3a1ee47, passed because coverage increased by 0% when compared to adjusted base (51.13%)

Details

Codecov Report

Attention: Patch coverage is 66.66667% with 5 lines in your changes missing coverage. Please review.

Project coverage is 51.13%. Comparing base (3a1ee47) to head (c152dfe).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
internal/credentials/kubernetes/database.go 66.66% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3110      +/-   ##
==========================================
- Coverage   51.14%   51.13%   -0.01%     
==========================================
  Files         283      283              
  Lines       25469    25483      +14     
==========================================
+ Hits        13026    13032       +6     
- Misses      11750    11757       +7     
- Partials      693      694       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.