-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(controller): expressions: fix quote() of a json object #3111
Conversation
Signed-off-by: Kent Rancourt <[email protected]>
✅ Deploy Preview for docs-kargo-io ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3111 +/- ##
==========================================
- Coverage 51.14% 51.14% -0.01%
==========================================
Files 283 283
Lines 25474 25479 +5
==========================================
+ Hits 13028 13030 +2
- Misses 11752 11754 +2
- Partials 694 695 +1 ☔ View full report in Codecov by Sentry. |
Totally agree. The example of posting to Slack is probably a good place for this. Knocking this down to a draft until I can fix that in the morning. |
Signed-off-by: Kent Rancourt <[email protected]>
Fixed the Slack example. |
@@ -1452,8 +1455,8 @@ steps: | |||
- name: Content-Type | |||
value: application/json | |||
body: | | |||
{ | |||
"channel": ${{ vars.slackChannel }}, | |||
${{ quote({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The existing example was actually wrong without this.
Signed-off-by: Kent Rancourt <[email protected]> (cherry picked from commit 019169f)
Successfully created backport PR for |
Signed-off-by: Kent Rancourt <[email protected]>
Signed-off-by: Kent Rancourt <[email protected]>
Fixes #3109
cc @muenchdo thanks for discovering this issue.