Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(backport release-1.1): fix(controller): expressions: fix quote() of a json object #3116

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

akuitybot
Copy link

Automated backport to release-1.1, triggered by a label in #3111.

Copy link

netlify bot commented Dec 10, 2024

Deploy Preview for docs-kargo-io ready!

Name Link
🔨 Latest commit f8cc08c
🔍 Latest deploy log https://app.netlify.com/sites/docs-kargo-io/deploys/675854911360c000082dde8a
😎 Deploy Preview https://deploy-preview-3116.docs.kargo.io
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@krancour krancour added this to the v1.1.2 milestone Dec 10, 2024
@krancour krancour enabled auto-merge (squash) December 10, 2024 14:52
Copy link

codecov bot commented Dec 10, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 51.15%. Comparing base (31d32d7) to head (f8cc08c).
Report is 1 commits behind head on release-1.1.

Files with missing lines Patch % Lines
internal/expressions/json_templates.go 50.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##           release-1.1    #3116      +/-   ##
===============================================
- Coverage        51.15%   51.15%   -0.01%     
===============================================
  Files              283      283              
  Lines            25471    25476       +5     
===============================================
+ Hits             13030    13032       +2     
- Misses           11748    11750       +2     
- Partials           693      694       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@krancour krancour merged commit d6a1bbd into release-1.1 Dec 10, 2024
22 of 23 checks passed
@krancour krancour deleted the backport-3111-to-release-1.1 branch December 10, 2024 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants