Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(backport release-1.1): fix(controller): fix tricky expr evaluation cases dealing with quotes and newlines #3186

Merged
merged 1 commit into from
Dec 23, 2024

fix(controller): fix tricky expr evaluation cases dealing with quotes…

d3b8f46
Select commit
Loading
Failed to load commit list.
Merged

chore(backport release-1.1): fix(controller): fix tricky expr evaluation cases dealing with quotes and newlines #3186

fix(controller): fix tricky expr evaluation cases dealing with quotes…
d3b8f46
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Dec 23, 2024 in 0s

51.17% (+0.00%) compared to 3b6fba1

View this Pull Request on Codecov

51.17% (+0.00%) compared to 3b6fba1

Details

Codecov Report

Attention: Patch coverage is 85.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 51.17%. Comparing base (3b6fba1) to head (d3b8f46).

Files with missing lines Patch % Lines
internal/expressions/json_templates.go 85.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           release-1.1    #3186   +/-   ##
============================================
  Coverage        51.17%   51.17%           
============================================
  Files              285      285           
  Lines            25619    25627    +8     
============================================
+ Hits             13110    13115    +5     
- Misses           11812    11814    +2     
- Partials           697      698    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.