Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Mount path /tmp as emptyDir volume #3218

Merged
merged 4 commits into from
Jan 8, 2025
Merged

Conversation

ggogel
Copy link
Contributor

@ggogel ggogel commented Jan 6, 2025

Closes #3150

Mounting an emptyDir volume to the path /tmp, which Kargo uses as target for cloning git repositories. This allows enabling the securityContext readOnlyRootFilesystem.

I deployed the chart to our test environment and tested it with the quickstart tutorial from the docs.

@ggogel ggogel requested a review from a team as a code owner January 6, 2025 12:37
Copy link

netlify bot commented Jan 6, 2025

Deploy Preview for docs-kargo-io ready!

Name Link
🔨 Latest commit a2ee4e0
🔍 Latest deploy log https://app.netlify.com/sites/docs-kargo-io/deploys/677bf98a7a2f1d00087deec9
😎 Deploy Preview https://deploy-preview-3218.docs.kargo.io
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Jan 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.40%. Comparing base (bb95eb4) to head (a2ee4e0).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3218   +/-   ##
=======================================
  Coverage   51.40%   51.40%           
=======================================
  Files         288      288           
  Lines       26108    26108           
=======================================
  Hits        13421    13421           
  Misses      11961    11961           
  Partials      726      726           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@krancour krancour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @ggogel!

@krancour krancour merged commit 85bba5a into akuity:main Jan 8, 2025
16 of 17 checks passed
fykaa pushed a commit to fykaa/kargo that referenced this pull request Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mount path /tmp as emptyDir volume
2 participants