Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Fix dlwrap on riscv64 #270

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

piggynl
Copy link

@piggynl piggynl commented Apr 7, 2022

@andreabolognani
Copy link

Hi, can the maintainers please take a look at this patch?

I can't claim that I fully understand what it does, but I can confirm that applying it on top of 1.5.10 makes it possible to successfully build the Fedora package on riscv64.

The approach currently used on Fedora (where riscv64 is not yet an officially supported architecture) and Debian (where it already is) is to simply skip the test suite altogether, which is clearly not ideal. See the Fedora hack and the Debian one for reference.

There is a PR that is trying to get the patch added to the Fedora package: this is much more likely to move forward if the patch in question had already been accepted upstream. And of course we want a future upstream release to work out of the box.

Thanks in advance for your consideration!

@andreabolognani
Copy link

@ebassi any chance you could look into this? It would be really great to have this fix (or an equivalent one) merged so that we can build and test libepoxy properly on riscv64. Thanks!

@andreabolognani
Copy link

@ebassi another friendly ping :)

@ebassi
Copy link
Collaborator

ebassi commented Dec 16, 2024

I don't have access to any RISC-V board, so I can't validate the pull request; all I can do is trust the fix, and merge it, which I plan to do for the next release of libepoxy. I have been busy with ${DAY_JOB}, and there have been a few other pull requests on the queue.

@andreabolognani
Copy link

@ebassi no worries, we're all busy one way or another so the intent behind my pings was simply to ensure that this wouldn't fall between the cracks :)

If you don't have any riscv64 hardware handy, you can go the emulation route. It's going to require some patience since things are obviously going to be a bit slow, but it should be relatively straightforward. The process is documented on the Fedora wiki and I'm happy to provide additional assistance should you need it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants