Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix for #63 invalid arguments retrieving info for some prs #75

Merged
merged 3 commits into from
Jan 8, 2024
Merged

Bugfix for #63 invalid arguments retrieving info for some prs #75

merged 3 commits into from
Jan 8, 2024

Conversation

schneim
Copy link

@schneim schneim commented Mar 12, 2023

updateShowOptions() assumed that all comments have line information. This is not the case for file comments.
So the line was undefined and caused the exception with invalid arguments.

schneim added 2 commits March 12, 2023 10:03
not reference/selection in the content. Need to be removed.
@nonameolsson
Copy link

Any updates on this one?

@ankitbko
Copy link
Owner

ankitbko commented Jan 8, 2024

Fixes #63

@ankitbko ankitbko merged commit 3a80875 into ankitbko:master Jan 8, 2024
1 check failed
Copy link

github-actions bot commented Jan 8, 2024

Unit Test Results

    1 files  ±0    60 suites  ±0   36m 40s ⏱️ ±0s
181 tests ±0  171 ✔️ ±0  0 💤 ±0  10 ❌ ±0 

For more details on these failures, see this check.

Results for commit 3a80875. ± Comparison against base commit 2f4aacd.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants