Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring circuit.py Class #4538

Merged
merged 5 commits into from
Apr 19, 2024
Merged

Refactoring circuit.py Class #4538

merged 5 commits into from
Apr 19, 2024

Conversation

maxcapodi78
Copy link
Collaborator

No description provided.

@maxcapodi78 maxcapodi78 added this to the v1.0 milestone Apr 18, 2024
@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@github-actions github-actions bot added examples maintenance Package and maintenance related labels Apr 18, 2024
pyaedt/circuit.py Outdated Show resolved Hide resolved
pyaedt/circuit.py Outdated Show resolved Hide resolved
pyaedt/circuit.py Outdated Show resolved Hide resolved
pyaedt/circuit.py Outdated Show resolved Hide resolved
pyaedt/circuit.py Outdated Show resolved Hide resolved
pyaedt/circuit.py Outdated Show resolved Hide resolved
pyaedt/circuit.py Outdated Show resolved Hide resolved
pyaedt/circuit.py Outdated Show resolved Hide resolved
pyaedt/circuit.py Outdated Show resolved Hide resolved
pyaedt/circuit.py Outdated Show resolved Hide resolved
pyaedt/circuit.py Outdated Show resolved Hide resolved
pyaedt/circuit.py Outdated Show resolved Hide resolved
pyaedt/circuit.py Outdated Show resolved Hide resolved
pyaedt/circuit.py Outdated Show resolved Hide resolved
pyaedt/circuit.py Outdated Show resolved Hide resolved
pyaedt/circuit.py Outdated Show resolved Hide resolved
pyaedt/circuit.py Outdated Show resolved Hide resolved
pyaedt/circuit.py Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Apr 19, 2024

Codecov Report

Attention: Patch coverage is 85.10638% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 81.50%. Comparing base (567fd28) to head (8ad24d3).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4538      +/-   ##
==========================================
- Coverage   81.57%   81.50%   -0.08%     
==========================================
  Files         110      110              
  Lines       53594    53731     +137     
==========================================
+ Hits        43721    43793      +72     
- Misses       9873     9938      +65     

Copy link
Member

@Samuelopez-ansys Samuelopez-ansys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Samuelopez-ansys Samuelopez-ansys merged commit 6451c98 into main Apr 19, 2024
15 checks passed
@Samuelopez-ansys Samuelopez-ansys deleted the circuit_arguments branch April 19, 2024 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Package and maintenance related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants