Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix layout of the "Solve Conflicts" modal #1470

Conversation

Antonio-Maranhao
Copy link
Contributor

@Antonio-Maranhao Antonio-Maranhao commented Jan 17, 2025

Overview

Fix alignment of the footer elements in the "Solve Conflicts" confirmation modal:

  • Align checkbox with the description text above
  • Remove unnecessary <div class="col-auto">

Includes:

  • fixes from npm audit fix
  • use Node 20 in GitHub actions because the npm installed requires Node 20+

Testing recommendations

Open a document with conflicts, then click 'Select as winner' button to show the Modal.

GitHub issue number

n/a

Related Pull Requests

n/a

Checklist

  • Code is written and works correctly;
  • Changes are covered by tests;
  • Documentation reflects the changes;
  • Update rebar.config.script with the correct tag once a new Fauxton release is made

Update packages: cross-spawn, express, path-to-regexp,
http-proxy-middleware, nanoid
@Antonio-Maranhao Antonio-Maranhao force-pushed the fix-layout-conflicts-confirmation-modal branch from 290bcbe to b375bd4 Compare January 17, 2025 19:20
@Antonio-Maranhao Antonio-Maranhao force-pushed the fix-layout-conflicts-confirmation-modal branch from 6da0be8 to bbf7c3d Compare January 17, 2025 20:34
@Antonio-Maranhao Antonio-Maranhao merged commit 44d0683 into apache:main Jan 20, 2025
3 checks passed
@Antonio-Maranhao Antonio-Maranhao deleted the fix-layout-conflicts-confirmation-modal branch January 20, 2025 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants