Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add summary to result file and update state machine checks #32

Merged
merged 2 commits into from
Sep 17, 2024
Merged

Add summary to result file and update state machine checks #32

merged 2 commits into from
Sep 17, 2024

Conversation

hoangtungdinh
Copy link
Contributor

@hoangtungdinh hoangtungdinh commented Sep 17, 2024 •
edited
Loading

Description

Add summary to the result file. Also update the logic to check state machine.

Main changes

  1. Add automatically generated summary.
  2. Add error to summary.
  3. Add reason to skip check.
  4. Continue checking if one state machine has a problem.

How was the PR tested?

  1. Inspect some output files manually.
  2. Unit tests

Notes
Related issue: asam-ev/qc-framework#161

romanodanilo
romanodanilo approved these changes Sep 17, 2024
View reviewed changes
Copy link
Contributor

@romanodanilo romanodanilo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @hoangtungdinh

@hoangtungdinh hoangtungdinh merged commit 55e0cd5 into develop Sep 17, 2024
6 checks passed
@hoangtungdinh hoangtungdinh deleted the tung/summary branch September 17, 2024 09:52
hoangtungdinh added a commit that referenced this pull request Sep 25, 2024
@hoangtungdinh
Add summary to result file and update state machine checks (#32)
7116f64 
Signed-off-by: hoangtungdinh <[email protected]>
@hoangtungdinh hoangtungdinh mentioned this pull request Sep 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romanodanilo romanodanilo romanodanilo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hoangtungdinh @romanodanilo