feat: implement handling and execution of oracle data #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noot
added a commit
to astriaorg/astria
that referenced
this pull request
Jan 20, 2025
## Summary update geth charts for oracle genesis values. ## Background geth charts needed to be updated for the oracle integration; see astriaorg/astria-geth#62 ## Changes - add `astriaOracleCallerAddress` and `astriaOracleContractAddress` config values - add oracle contract bytecode to genesis alloc at `astriaOracleContractAddress` - update dev tags for geth and sequencer ## Testing ran it end-to-end with the usual dev cluster instructions and queried the oracle contract for price updates via the instructions here: https://github.com/astriaorg/astria-oracle-contracts/tree/main?tab=readme-ov-file#query-contract
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
implement handling of oracle data received via the execution API.
see relevant contract for context: https://github.com/astriaorg/astria-oracle-contracts/blob/main/src/AstriaOracle.sol
flow is as follows:
AstriaOraclecontract is deployed on the rollup and the address is set in genesisRollupData.OracleDatavia the execution API, which consists of a vector of price updates, it converts these into contract calls toAstriaOracle.initializeCurrencyPairbefore callingupdatePriceData. this is needed to set the decimals for that pair, which is not updated once the pair has been initialized.other changes:
DepositTxtoInjectedTx, as the same type is now being used for deposits and oracle updates. it was not necessary to create a new type, as the previous erc20 calls being done by theDepositTxwere generic to what they were calling.grpc/execution/validation.govalidation and conversion function into separate functions for eachRollupDatatype, no logic was changed for Deposit/SequencedData.testing:
pr-1866and the geth image on this PR. prices are updated in the contract state correctly.