-
-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to exclude local background in residual image (#1690) #1691
Conversation
…_residual_image() This commit addresses issue astropy#1690.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @m-samland. I have just a few suggested changes.
Co-authored-by: Larry Bradley <[email protected]>
Hello @m-samland! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2024-02-12 15:27:58 UTC |
Co-authored-by: Larry Bradley <[email protected]>
Co-authored-by: Larry Bradley <[email protected]>
Co-authored-by: Larry Bradley <[email protected]>
Co-authored-by: Larry Bradley <[email protected]>
Co-authored-by: Larry Bradley <[email protected]>
Co-authored-by: Larry Bradley <[email protected]>
Thanks for the suggestions @larrybradley, I commited them. Happy to have this merged. :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again, @m-samland. This needs a test and a changelog entry, but I'll add those in a followup PR. I'm also considering making the default be to not include the local background subtraction (unfortunately that would be a breaking change, but it might be sensible).
Can the same feature (to turn off local bkg) be supported for |
@SterlingYM Yes, I'll add that feature to |
@SterlingYM This was added in #1756. |
This pull request is to solve issue #1690. I added a new keyword to the function
make_model_image' and
make_residual_image' of the PSFPhotometry-class to toggle whether the local background model is included or not.The changes should not break existing code, as far as I can tell.
Closes #1690