Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add debug log line for global curl initialization #467

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Add debug log line for global curl initialization #467

wants to merge 1 commit into from

Conversation

sirknightj
Copy link
Contributor

@sirknightj sirknightj commented Jan 25, 2025 •
edited
Loading

Issue #, if available:
awslabs/amazon-kinesis-video-streams-producer-sdk-cpp#1226

What was changed?

  • Adding a debug log line above and below curl initialization
  • While I'm at it, also move the sanitizers to using DRY principle.

Why was it changed?

  • That line resulted in a segfault when run from my CLion terminal, but not from my normal terminal, when running the gstreamer tests.
  • Adding it to help others pinpoint trouble locations quicker.

How was it changed?

  • Review the files changed tab in the pull request.

What testing was done for the changes?

  • For this level of changes, the CI is more than sufficient.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@sirknightj sirknightj added the ci label Jan 27, 2025
@sirknightj sirknightj force-pushed the curl-logline branch 2 times, most recently from 7b7ddf6 to 2e93b64 Compare January 27, 2025 03:56
@sirknightj sirknightj mentioned this pull request Jan 27, 2025
Open
@sirknightj sirknightj force-pushed the curl-logline branch 8 times, most recently from 9de41dd to a8acd3c Compare January 27, 2025 06:49
@sirknightj sirknightj force-pushed the curl-logline branch 2 times, most recently from d451f40 to fc69275 Compare February 5, 2025 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
1.5.5 ci
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@sirknightj