Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clarify naming of AWS KMS keyring #67

Closed
mattsb42-aws opened this issue Jan 30, 2020 · 3 comments
Closed

clarify naming of AWS KMS keyring #67

mattsb42-aws opened this issue Jan 30, 2020 · 3 comments
Assignees
@acioc
Labels
bug Something isn't working Doc impact Requires a change to AWS documentation
Milestone
Spec 1.0 (Officia...

Comments

@mattsb42-aws
Copy link
Member

We currently just call the AWS KMS keyring the "KMS keyring". AWS KMS is not the only thing called "KMS". We should be explicit in our naming.
@mattsb42-aws mattsb42-aws added the bug Something isn't working label Jan 30, 2020
This was referenced Jan 30, 2020
Merged
Closed
@juneb
Copy link
Contributor

juneb commented Feb 11, 2020

Please add a 'doc impact' label to this issue.

@mattsb42-aws mattsb42-aws added the Doc impact Requires a change to AWS documentation label Feb 11, 2020
@mattsb42-aws
Copy link
Member Author

Updating here: we agreed that we want to do this prior to releasing keyrings in Java and Python.

This was referenced Apr 16, 2020
Closed
Open
Open
Closed
@seebees seebees mentioned this issue Apr 28, 2020
Closed
@mattsb42-aws mattsb42-aws added this to the keyrings milestone May 15, 2020
@acioc acioc self-assigned this May 26, 2020
@acioc acioc mentioned this issue Jun 1, 2020
Merged
@acioc acioc mentioned this issue Jun 3, 2020
Open
@acioc
Copy link
Contributor

acioc commented Jun 3, 2020

Closing in favor of tracking issue: #127

@acioc acioc closed this as completed Jun 3, 2020
josecorella pushed a commit that referenced this issue Jun 7, 2023
@lavaleri @josecorella
feat: Add requirements on decryption materials around existence of sy…
68b9bfb 
…mmetric signing key (#67)
josecorella pushed a commit that referenced this issue Jun 7, 2023
@lavaleri @josecorella
feat: Add requirements on decryption materials around existence of sy…
eb609ce 
…mmetric signing key (#67)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@acioc acioc

Labels
bug Something isn't working Doc impact Requires a change to AWS documentation
Projects
None yet
Milestone
Spec 1.0 (Official Keyring Release)
Development

No branches or pull requests
3 participants
@juneb @acioc @mattsb42-aws