Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Clarify naming of KMS to AWS KMS #124

Merged
merged 2 commits into from
Jun 2, 2020
Merged

Conversation

acioc
Copy link
Contributor

@acioc acioc commented Jun 1, 2020

Issue #, if available:

Description of changes:

  • Clarify naming of KMS to AWS KMS

Follow Ups:

  • Move kms-keyring file to aws-kms-keyring

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@acioc acioc self-assigned this Jun 1, 2020
framework/keyring-interface.md Outdated Show resolved Hide resolved
framework/kms-keyring.md Outdated Show resolved Hide resolved
framework/structures.md Outdated Show resolved Hide resolved
@mattsb42-aws
Copy link
Member

Thinking about this also, I think that these should be Z increments, not Y. I would classify this as a "fix", not a "feature".

@acioc
Copy link
Contributor Author

acioc commented Jun 2, 2020

Thinking about this also, I think that these should be Z increments, not Y. I would classify this as a "fix", not a "feature".

That's fair - I wasn't really sure how we handle versioning here. Updating to 0.2.1 instead of 0.3.0

@acioc acioc requested a review from mattsb42-aws June 2, 2020 17:46
@mattsb42-aws
Copy link
Member

I wasn't really sure how we handle versioning here

Yup; that's on me :) #35

Copy link
Member

@mattsb42-aws mattsb42-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@acioc
Copy link
Contributor Author

acioc commented Jun 2, 2020

Merging this and fixing the merge conflicts with #123

Will follow up once #123 is merged with a PR moving the AWS KMS keyring page to aws-kms-keyring.md

@acioc acioc merged commit 62a9bd2 into awslabs:master Jun 2, 2020
@acioc acioc deleted the awskms branch June 2, 2020 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants