Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update Key IDs and generator sections to reference valid AWS KMS values, additional naming clarity #123

Merged
merged 8 commits into from
Jun 4, 2020

Conversation

acioc
Copy link
Contributor

@acioc acioc commented Jun 1, 2020

Issue #, if available:

Description of changes:

  • Rename Key IDs to Key Names for increased clarity
  • Update Key Names and Generator sections to reinforce support for all AWS KMS key identifiers

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link
Member

@mattsb42-aws mattsb42-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

General syntax/voice comment: don't say that "a thing will do an action"; say that "a thing does an action".

framework/kms-keyring.md Outdated Show resolved Hide resolved
framework/kms-keyring.md Outdated Show resolved Hide resolved
framework/kms-keyring.md Outdated Show resolved Hide resolved
framework/kms-keyring.md Outdated Show resolved Hide resolved
framework/kms-keyring.md Outdated Show resolved Hide resolved
framework/kms-keyring.md Outdated Show resolved Hide resolved
framework/kms-keyring.md Outdated Show resolved Hide resolved
framework/kms-keyring.md Outdated Show resolved Hide resolved
framework/kms-keyring.md Outdated Show resolved Hide resolved
framework/kms-keyring.md Outdated Show resolved Hide resolved
@acioc
Copy link
Contributor Author

acioc commented Jun 2, 2020

General syntax/voice comment: don't say that "a thing will do an action"; say that "a thing does an action".

Good call. I will remove "will" from these sections.

@acioc acioc requested a review from mattsb42-aws June 2, 2020 18:24
seebees
seebees previously approved these changes Jun 4, 2020
Copy link
Contributor

@seebees seebees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

framework/kms-keyring.md Outdated Show resolved Hide resolved
framework/kms-keyring.md Outdated Show resolved Hide resolved
framework/kms-keyring.md Outdated Show resolved Hide resolved
framework/kms-keyring.md Outdated Show resolved Hide resolved
framework/kms-keyring.md Outdated Show resolved Hide resolved
Applying suggested wording changes.

Co-authored-by: Matt Bullock <[email protected]>
@seebees seebees mentioned this pull request Jul 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants