Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

22417 refactor smoke tests #1533

Merged
merged 5 commits into from
Aug 12, 2024
Merged

Conversation

EPortman
Copy link
Collaborator

@EPortman EPortman commented Aug 6, 2024

Issue #: 22417
https://app.zenhub.com/workspaces/names-team-board-new-655554cbddd49510027dad2e/issues/gh/bcgov/entity/22417

Description of changes:

  • Added a bunch of data-testids to app/
  • Cleaned up smoke tests in testing/
  • Added testing for approval, rejection, hold, and edit.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the namex license (Apache 2.0).

Copy link
Collaborator

@eve-git eve-git left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EPortman EPortman merged commit 773bc1b into bcgov:main Aug 12, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants