Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document the release process and update the "release-it" options #293

Merged
merged 2 commits into from
Sep 26, 2019

Conversation

ttmc
Copy link
Contributor

@ttmc ttmc commented May 22, 2019

This is to help with issue #292

I hope the process is mostly correct. I wasn't able to test it. Please take a look to make sure it makes sense. Once someone uses it, they might find something that should be changed or clarified.

@codecov-io
Copy link

codecov-io commented May 22, 2019

Codecov Report

Merging #293 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #293   +/-   ##
=======================================
  Coverage   95.14%   95.14%           
=======================================
  Files          12       12           
  Lines         309      309           
=======================================
  Hits          294      294           
  Misses         15       15

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba81d1b...667e2c9. Read the comment docs.

@ttmc
Copy link
Contributor Author

ttmc commented May 23, 2019

I realized I forgot to include the signed-off-by line in the Git commit messages, so I will see if I can fix those.

@ttmc ttmc force-pushed the add-release-process branch from a6d63c7 to 667e2c9 Compare May 23, 2019 07:21
@ttmc
Copy link
Contributor Author

ttmc commented May 23, 2019

I had to do a force-push of the revised commits, but it looks like it worked. Disaster averted!

@eckelj
Copy link
Contributor

eckelj commented May 23, 2019 via email

@future-is-present
Copy link
Contributor

release-it latest version is now 12.4.1 but everything should work as well with 12.2.0.
Since a lot of packages needs to be updated this can be done in another PR, therefore I will approve it.

@future-is-present future-is-present merged commit ea57280 into master Sep 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants