Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge changes in to support parsing bash scripts #737

Open
wants to merge 44 commits into
base: future
Choose a base branch
from
Open

Merge changes in to support parsing bash scripts #737

wants to merge 44 commits into from

Conversation

BolunThompson
Copy link
Contributor

Code written by @sethsabar. The tests pass with the changes from binpash/shasta#5 and binpash/libbash#1 (CI will fail until those are merged in).

sethsabar added 21 commits March 19, 2024 17:48
@sethsabar
starting to integrate bash into pash
5931c60
@sethsabar
[untested] add bash expansion for bash parser
132d180
@sethsabar
outline for ast_to_ast updates
48501ef
@sethsabar
ast_to_ast updates complete but untested
29f63ff
@sethsabar
some testing on ast_to_ast changes
9b2a9a2
@sethsabar
outline for ast_to_ir
963c6a9
@sethsabar
some work on ast_to_ir
1ea0b9c
@sethsabar
fixed bash mode not propogating to JIT engine
ed8f1a0
@sethsabar
update requirements for actions tests
e861a45
@sethsabar
minor bug fixes and new bash testing script
9218ec0
@sethsabar
make changes to test scripts to support bash
ca85a45
@sethsabar
some work on the bash testing
958a355
@sethsabar
Add bash tests
164ed4b
@sethsabar
start work on benchmarking
d73a0cb
@sethsabar
updates to the bash benchmark routine
3da7bd2
@sethsabar
bug fixed with echo ast, crazy bash speed ups now
dbeaaaa
@sethsabar
getting ready to run evaluations
058fd15
@sethsabar
bug fix to attain more speedups
46b8559
@sethsabar
add another benchmark script
57187d8
@sethsabar
nlp test suite
2610376
@sethsabar
bash evaluation script
e48ddbf
@BolunThompson
Merge branch 'main' of https://github.com/sethsabar/pash into bash-merge
a44723c 
Signed-off-by: Bolun Thompson <[email protected]>
@BolunThompson
Fix: python 3.8 compat
e817bb3 
Signed-off-by: Bolun Thompson <[email protected]>
@BolunThompson
Split up big function
3050c4e 
Signed-off-by: Bolun Thompson <[email protected]>
@BolunThompson
Fix tmpdir in tests
b430454 
Signed-off-by: Bolun Thompson <[email protected]>
@BolunThompson
Add 'encoding="utf-8"' to open calls for writing
c40fa53 
The bash tests contain scripts which use UTF-8 only characters,
but, by default, Python throws an exception when writing non-ASCII
characters to a file.

Signed-off-by: Bolun Thompson <[email protected]>
@BolunThompson
Lint: black bash changes
3b238c7 
Signed-off-by: Bolun Thompson <[email protected]>
@BolunThompson
Add comments
21576ce 
Signed-off-by: Bolun Thompson <[email protected]>
@BolunThompson
Update shasta version
b550e15 
Signed-off-by: Bolun Thompson <[email protected]>
@github-actions GitHub Actions
Copy link

OS =
CPU =
Ram =
Hash = 360fc2e
Kernel=
||
|-|-|-|-|-|-|-|-|-|

@github-actions GitHub Actions
Copy link

OS =
CPU =
Ram =
Hash = 7b3cb4a
Kernel=
||
|-|-|-|-|-|-|-|-|-|

@BolunThompson
Remove failing bash evaluation tests
e957f08 
Due to the prescence of a '*' character in the sed/grep regex string
which is correctly interpreted as a glob conservatively.
@github-actions GitHub Actions
Copy link

OS =
CPU =
Ram =
Hash = e957f08
Kernel=
||
|-|-|-|-|-|-|-|-|-|

@github-actions GitHub Actions
Copy link

OS:ubuntu-20.04
Thu Jan 23 02:18:43 UTC 2025
intro: 2/2 tests passed.
interface: 202/203 tests passed.
compiler: 100/100 tests passed.
test_histexp7.sub are not identical

@github-actions GitHub Actions
Copy link

OS =
CPU =
Ram =
Hash = eedd28e
Kernel=
||
|-|-|-|-|-|-|-|-|-|

@github-actions GitHub Actions
Copy link

OS:ubuntu-20.04
Thu Jan 23 03:36:37 UTC 2025
intro: 2/2 tests passed.
interface: 202/202 tests passed.
compiler: 100/100 tests passed.

@BolunThompson
Copy link
Contributor Author

The tests all pass, so this should be ready for review.

angelhof
angelhof approved these changes Jan 23, 2025
View reviewed changes
Copy link
Member

@angelhof angelhof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me! Could we also add a sentence in README saying that if your script includes bash syntax you can use the beta --bash flag to support it? Also adding a few paragraphs in docs/bash.md to talk about the architecture of the solution?

@github-actions GitHub Actions
Copy link

OS =
CPU =
Ram =
Hash = e097512
Kernel=
||
|-|-|-|-|-|-|-|-|-|

@github-actions GitHub Actions
Copy link

OS =
CPU =
Ram =
Hash = e951405
Kernel=
||
|-|-|-|-|-|-|-|-|-|

@github-actions GitHub Actions
Copy link

OS =
CPU =
Ram =
Hash = b3079df
Kernel=
||
|-|-|-|-|-|-|-|-|-|

@BolunThompson
doc edits
c6dbe32 
Signed-off-by: Bolun Thompson <[email protected]>
@github-actions GitHub Actions
Copy link

OS =
CPU =
Ram =
Hash = c6dbe32
Kernel=
||
|-|-|-|-|-|-|-|-|-|

@BolunThompson
Copy link
Contributor Author

I wrote some basic documentation — is this good or should I elaborate on some part?

@github-actions GitHub Actions
Copy link

OS:ubuntu-20.04
Mon Jan 27 04:59:40 UTC 2025
intro: 2/2 tests passed.
interface: 202/202 tests passed.
compiler: 100/100 tests passed.

@github-actions GitHub Actions
Copy link

OS:ubuntu-20.04
Mon Jan 27 05:02:46 UTC 2025
intro: 2/2 tests passed.
interface: 202/202 tests passed.
compiler: 100/100 tests passed.

@github-actions GitHub Actions
Copy link

OS:ubuntu-20.04
Mon Jan 27 05:04:18 UTC 2025
intro: 2/2 tests passed.
interface: 202/202 tests passed.
compiler: 100/100 tests passed.

@github-actions GitHub Actions
Copy link

OS:ubuntu-20.04
Mon Jan 27 05:07:15 UTC 2025
intro: 2/2 tests passed.
interface: 202/202 tests passed.
compiler: 100/100 tests passed.

@BolunThompson
Add bash intro test
16bf931 
Signed-off-by: Bolun Thompson <[email protected]>
@github-actions GitHub Actions
Copy link

OS =
CPU =
Ram =
Hash = 16bf931
Kernel=
||
|-|-|-|-|-|-|-|-|-|

@github-actions GitHub Actions
Copy link

OS:ubuntu-20.04
Mon Jan 27 05:57:38 UTC 2025
intro: 2/3 tests passed.
interface: 202/202 tests passed.
compiler: 100/100 tests passed.
hello-world-bash.sh are not identical

This was referenced Jan 27, 2025
Merged
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@angelhof angelhof angelhof approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BolunThompson @angelhof @sethsabar