-
Notifications
You must be signed in to change notification settings - Fork 900
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Calculate latency, receive uplink RSSI, calculate bandwidth congestion and packet rate #492
Conversation
- Moved latency measurement from the radio driver to a new Latency class for better organization and readability. - Generalized the LinkStatistics class to allow for easy addition of other link statistics in the future.
In a valiant attempt to appease the relentless gods of autopep8 and the all-seeing eyes of CI, I embarked on an epic journey to fix double-quoted strings and reorder imports.
- Modified start() and stop() methods for better thread management. - Implemented thread reinitialization on start after stop.
- Refactor link quality callback to contain signal health obj with additional signal health information - Parse uplink RSSI in ack into signal health obj
Return a dictionary with all updated signal quality statistics in the callback, rather than the entire class.
Renamed SignalHealth class to RadioLinkStatistics to better reflect its responsibility of handling and processing radio-specific metrics.
In the last commit, I renamed the I also want to bring up the consideration of feeding data from |
- Move radio link statistics into (universal) link statistics object - Stop updating radio link statistics from callbacks if stop is called on link statistics. User probably will expect this behavior. - Deprecation warning on calling link_quality_updated directly. Proxy call to link_statistics.link_quality_updated until removal.
These generally should be visible and fixed. + fix deprecated setDaemon warnings
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me as a first implementation. This is a great improvement to the lib!
Awesome work @gemenerik, it is merged. |
Since bitcraze/crazyflie-lib-python#492 there is a default implementation in the lib for latency. Retrieve the latency from here instead of using the custom implementation. This means we stop discerning between large and small packet latency.
Since bitcraze/crazyflie-lib-python#492 there is a default implementation in the lib for latency. Retrieve the latency from here instead of using the custom implementation. This means we stop discerning between large and small packet latency.
Continuation of #480 and #477
🚀 Features
Introduces a framework for link statistics, enabling the tracking of various metrics, starting with latency measurement.
Refactors link quality callback to contain signal health obj with additional signal health information:
📝 To-do
The implementation improves the lib's ability to monitor communication quality and lays the groundwork for further enhancements in link statistics.