feat: use testgen-hs for deserializing ApplyTxErrors
#93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying blockfrost-platform with
|
| Latest commit: |
df8f27d
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://921a306f.blockfrost-platform.pages.dev |
| Branch Preview URL: | https://feat-haskell-cbor-deserializ.blockfrost-platform.pages.dev |
michalrus
force-pushed
the
feat/haskell-cbor-deserializer
branch
from
cf100a5 to
8e60e29
Compare
michalrus
force-pushed
the
feat/haskell-cbor-deserializer
branch
from
9fe6fa4 to
4299eba
Compare
Artifacts being: GitHub Workflow artifacts (including Windows), Nix packages, Docker image.
michalrus
force-pushed
the
feat/haskell-cbor-deserializer
branch
from
3f28303 to
5275170
Compare
michalrus
requested review from
vladimirvolek,
ginnun and
gytis-ivaskevicius
This was referenced Nov 29, 2024
michalrus
added a commit
that referenced
this pull request
Dec 3, 2024
Related to #42. Follow up to #93. I realized that we potentially have an infinite loop (although each iteration slept for 1 s). If a user broke the deployment so that `testgen-hs` became inaccessible, the request to deserialize a CBOR would never be fulfilled, not even with an error. We only returned deserialization errors from a working Haskell tool itself. Lower-level errors were only logged to our `stdout`. After this change, a "repeated internal failure" is returned after the *2nd* attempt to deserialize the same request fails on a lower level (e.g. because the child binary cannot be found, because someone moved it).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Related to #42.
See the video in Slack.
Important Changes Introduced
Now, transaction errors are being deserialized by the Haskell tool,
testgen-hs. It's built on Hydra, and kept in a separate repository with binary artifacts.The errors are processed in a streaming manner through
stdin/stdout(very fast) – we do not launch a new process for each request.But we are able to detect and self-heal when that worker process was killed from the outside (this is also tested in the unit test).