This repository has been archived by the owner on May 3, 2022. It is now read-only.
traffic controller: report better errors #258
Merged
+63
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* It is more useful when we actually report the number we mean, instead of the exact opposite: we were reporting number of pods ready and told the users that was the number of pods not ready. Now we report it correctly. * It's weird to report 0 pods not ready, but still not get any traffic. We add some more clarity on that by reporting that there are pods that haven't made it into the endpoints yet. This can be k8s taking its time to do its thing, or the service selector might be incorrect. We should be able to catch an incorrect selector in the future, see #257 [1]. * To remain consistent with the errors we report in the Release, we now suggest the specific command to run to get more information about the CapacityTarget. [1] #257
juliogreff
force-pushed
the
juliogreff/tt-pods-not-ready
branch
from
d972b71 to
86af693
Compare
osdrv
approved these changes
Jan 16, 2020
hihilla
approved these changes
Jan 20, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is more useful when we actually report the number we mean, instead
of the exact opposite: we were reporting number of pods ready and told
the users that was the number of pods not ready. Now we report it
correctly.
It's weird to report 0 pods not ready, but still not get any traffic.
We add some more clarity on that by reporting that there are pods that
haven't made it into the endpoints yet. This can be k8s taking its time
to do its thing, or the service selector might be incorrect. We should
be able to catch an incorrect selector in the future, see Validate Service's .spec.selector when shifting traffic #257.
To remain consistent with the errors we report in the Release, we now
suggest the specific command to run to get more information about the
CapacityTarget.