[Fix] 닉네임 설정 시 공백 제거 로직 추가 및 프로필 설정 화면 재 진입 시 설정된 프로필 로드 #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
choijungp
approved these changes
Dec 2, 2024
| .trimmingCharacters(in: .whitespacesAndNewlines) | ||
| else { return } | ||
|
|
||
| viewModel.action(input: .updateProfileNickname(nickname: completedNickname)) |
There was a problem hiding this comment.
요기서 updateProfileNickname이 필요한 이유는 앞 뒤 공백이 있을 시 제거한 것을 적용하기 위함인가유 ?
There was a problem hiding this comment.
마저유 ㅎㅎ
뷰모델에 있는 saveProfile이 profileSubject.value의 값으로 동작해서 그전에 업데이트~!!
Comment on lines
+62
to
+64
| private func resetProfile() { | ||
| profileSubject.value = profileUseCase.loadProfile() | ||
| } |
eemdeeks
approved these changes
Dec 2, 2024
조이가 알려줬습니다~~ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🌁 Background
📱 Screenshot
Simulator.Screen.Recording.-.iPhone.13.mini.-.2024-12-02.at.19.45.32.mp4
👩💻 Contents
✅ Testing
📣 Related Issue