Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] 닉네임 설정 시 공백 제거 로직 추가 및 프로필 설정 화면 재 진입 시 설정된 프로필 로드 #138

Merged
merged 1 commit into from
Dec 2, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -196,7 +196,11 @@ final class ProfileViewController: UIViewController {
private func updateProfileState(nickname: String) {
nicknameCountLabel.text = "\(nickname.count)/\(nicknameMaxCount)"
nicknameTextField.text = nickname
if !nickname.isEmpty {
let trimmedNickname = nickname.trimmingCharacters(in: .whitespacesAndNewlines)

if !nickname.isEmpty,
!trimmedNickname.isEmpty
{
completeButton.isEnabled = true
completeButton.tintColor = .airplainBlue
} else {
Expand All @@ -216,10 +220,18 @@ final class ProfileViewController: UIViewController {
}

@objc private func dismissView() {
viewModel.action(input: .resetProfile)
dismiss(animated: true)
}

@objc private func saveProfile() {
guard
let completedNickname = nicknameTextField
.text?
.trimmingCharacters(in: .whitespacesAndNewlines)
else { return }

viewModel.action(input: .updateProfileNickname(nickname: completedNickname))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

요기서 updateProfileNickname이 필요한 이유는 앞 뒤 공백이 있을 시 제거한 것을 적용하기 위함인가유 ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

마저유 ㅎㅎ
뷰모델에 있는 saveProfileprofileSubject.value의 값으로 동작해서 그전에 업데이트~!!

viewModel.action(input: .saveProfile)
dismiss(animated: true)
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ public final class ProfileViewModel: ViewModel {
case updateProfileNickname(nickname: String)
case updateProfileIcon(profileIcon: ProfileIcon)
case saveProfile
case resetProfile
}

struct Output {
Expand All @@ -33,9 +34,14 @@ public final class ProfileViewModel: ViewModel {

func action(input: Input) {
switch input {
case .updateProfileNickname(let nickname): updateProfileNickname(nickname: nickname)
case .updateProfileIcon(let profileIcon): updateProfileIcon(profileIcon: profileIcon)
case .saveProfile: saveProfile()
case .updateProfileNickname(let nickname):
updateProfileNickname(nickname: nickname)
case .updateProfileIcon(let profileIcon):
updateProfileIcon(profileIcon: profileIcon)
case .saveProfile:
saveProfile()
case .resetProfile:
resetProfile()
}
}

Expand All @@ -52,4 +58,8 @@ public final class ProfileViewModel: ViewModel {
private func saveProfile() {
profileUseCase.saveProfile(profile: profileSubject.value)
}

private func resetProfile() {
profileSubject.value = profileUseCase.loadProfile()
}
Comment on lines +62 to +64
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

굿뽀이 ~ 👍🏻

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

감삼다 ~~

}