-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix] 닉네임 설정 시 공백 제거 로직 추가 및 프로필 설정 화면 재 진입 시 설정된 프로필 로드 #138
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -14,6 +14,7 @@ public final class ProfileViewModel: ViewModel { | |
case updateProfileNickname(nickname: String) | ||
case updateProfileIcon(profileIcon: ProfileIcon) | ||
case saveProfile | ||
case resetProfile | ||
} | ||
|
||
struct Output { | ||
|
@@ -33,9 +34,14 @@ public final class ProfileViewModel: ViewModel { | |
|
||
func action(input: Input) { | ||
switch input { | ||
case .updateProfileNickname(let nickname): updateProfileNickname(nickname: nickname) | ||
case .updateProfileIcon(let profileIcon): updateProfileIcon(profileIcon: profileIcon) | ||
case .saveProfile: saveProfile() | ||
case .updateProfileNickname(let nickname): | ||
updateProfileNickname(nickname: nickname) | ||
case .updateProfileIcon(let profileIcon): | ||
updateProfileIcon(profileIcon: profileIcon) | ||
case .saveProfile: | ||
saveProfile() | ||
case .resetProfile: | ||
resetProfile() | ||
} | ||
} | ||
|
||
|
@@ -52,4 +58,8 @@ public final class ProfileViewModel: ViewModel { | |
private func saveProfile() { | ||
profileUseCase.saveProfile(profile: profileSubject.value) | ||
} | ||
|
||
private func resetProfile() { | ||
profileSubject.value = profileUseCase.loadProfile() | ||
} | ||
Comment on lines
+62
to
+64
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 굿뽀이 ~ 👍🏻 There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 감삼다 ~~ |
||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
요기서 updateProfileNickname이 필요한 이유는 앞 뒤 공백이 있을 시 제거한 것을 적용하기 위함인가유 ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
마저유 ㅎㅎ
뷰모델에 있는
saveProfile
이profileSubject.value
의 값으로 동작해서 그전에 업데이트~!!