Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change to use v3 test VDS instead of sparse MT #547

Merged
merged 1 commit into from
Jan 22, 2024
Merged

Change to use v3 test VDS instead of sparse MT #547

merged 1 commit into from
Jan 22, 2024

Conversation

jkgoodrich
Copy link
Contributor

No description provided.

@jkgoodrich jkgoodrich requested a review from matren395 January 19, 2024 17:12
@jkgoodrich jkgoodrich added the v3 label Jan 19, 2024
matren395
matren395 approved these changes Jan 19, 2024
View reviewed changes
Copy link
Contributor

@matren395 matren395 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense enough and all the code looks right - could you walk me through why this change is being made again before we approve it though ?

@jkgoodrich
Copy link
Contributor Author

Yup, this is just to use the new VDS of the test dataset instead of the sparse MT since we are moving completely to VDS it's more helpful to have the genomes test dataset available as a VDS

@jkgoodrich jkgoodrich merged commit 901f0d8 into main Jan 22, 2024
1 check passed
@jkgoodrich jkgoodrich deleted the jg/update_v3.1_test_vds branch January 22, 2024 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matren395 matren395 matren395 approved these changes

Assignees

@jkgoodrich jkgoodrich

@matren395 matren395

Labels
v3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jkgoodrich @matren395