Deprecate connectrpc es and query-es #1597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -3,7 +3,7 @@ name: buf.build/connectrpc/es | |||
| plugin_version: v1.6.1 | |||
| source_url: https://github.com/connectrpc/connect-es | |||
| integration_guide_url: https://connectrpc.com/docs/web/getting-started | |||
| description: Generates code that is compatible with browsers and Node.js for working with Connect, gRPC, and gRPC-Web. | |||
| description: Generates code that is compatible with browsers and Node.js for working with Connect, gRPC, and gRPC-Web. This plugin is deprecated, see [Migration Guide](https://github.com/connectrpc/connect-es/blob/v2.0.0/MIGRATING.md) to upgrade to the latest version. | |||
There was a problem hiding this comment.
Does the BSR's description field render markdown appropriately?
There was a problem hiding this comment.
It does not, I'll back out the links for now. But it'd be super handy to be able to link out, although you could argue that's the purpose of the "documentation" or "readme" section we'll be adding.
stefanvanburen
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR marks the following plugins as deprecated with a new description:
And updates the description for:
After this is merged/released, I'll make them as
disabled: truein the source. I don't recall if we use that for any logic outside the fetcher.