Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate connectrpc es and query-es #1597

Merged
merged 3 commits into from
Nov 20, 2024
Merged

Deprecate connectrpc es and query-es #1597

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0f1afa2
Deprecate connectrpc es and query-es
mfridman Nov 20, 2024
46580e4
further updates
mfridman Nov 20, 2024
245403b
remove links
mfridman Nov 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion plugins/connectrpc/es/v1.6.1/buf.plugin.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ name: buf.build/connectrpc/es
plugin_version: v1.6.1
source_url: https://github.com/connectrpc/connect-es
integration_guide_url: https://connectrpc.com/docs/web/getting-started
description: Generates code that is compatible with browsers and Node.js for working with Connect, gRPC, and gRPC-Web.
description: Generates code that is compatible with browsers and Node.js for working with Connect, gRPC, and gRPC-Web. This plugin is deprecated, see [Migration Guide](https://github.com/connectrpc/connect-es/blob/v2.0.0/MIGRATING.md) to upgrade to the latest version.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the BSR's description field render markdown appropriately?

Copy link
Member Author

@mfridman mfridman Nov 20, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does not, I'll back out the links for now. But it'd be super handy to be able to link out, although you could argue that's the purpose of the "documentation" or "readme" section we'll be adding.

deps:
- plugin: buf.build/bufbuild/es:v1.10.0
output_languages:
Expand All @@ -18,3 +18,4 @@ registry:
version: ^1.6.1
spdx_license_id: Apache-2.0
license_url: https://github.com/connectrpc/connect-es/blob/v1.6.1/LICENSE
deprecated: true
3 changes: 2 additions & 1 deletion plugins/connectrpc/query-es/v1.4.2/buf.plugin.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ name: buf.build/connectrpc/query-es
plugin_version: v1.4.2
source_url: https://github.com/connectrpc/connect-query-es
integration_guide_url: https://connectrpc.com/docs/web/query/getting-started
description: Generates client stubs for calling Connect services with TanStack Query.
description: Generates client stubs for calling Connect services with TanStack Query. This plugin is deprecated, see [Migration Guide](https://github.com/connectrpc/connect-es/blob/v2.0.0/MIGRATING.md) to upgrade to the latest version.
deps:
- plugin: buf.build/bufbuild/es:v1.10.0
output_languages:
Expand All @@ -20,3 +20,4 @@ registry:
version: ^v1.10.0
spdx_license_id: Apache-2.0
license_url: https://github.com/connectrpc/connect-query-es/blob/v1.4.2/LICENSE
deprecated: true