Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite spherical harmonics as class #374

Merged
merged 62 commits into from
Jul 12, 2024
Merged

Rewrite spherical harmonics as class #374

merged 62 commits into from
Jul 12, 2024

Conversation

jo-mueller
Copy link
Member

Description

This PR rewrites the spherical harmonics expansion functionality as its own class. The class is based upon the already existing Expander class and just overwrites some of its member functions

Type of Change

  • New feature (non-breaking change which adds functionality)
  • Documentation update

How Has This Been Tested?

  • Unit tests
  • Interactive tests

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented on my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@jo-mueller
added new classes for spherical harmonics expansion
6a9ca19
@jo-mueller
made classes public
2ad3e40
@jo-mueller
use new expansion function in napari menu
c95ec6b
@jo-mueller
Added tests
402212b
@jo-mueller
Updated docs
c4dbc1c
@jo-mueller
introduced residuals as separate measurements function
77f98e2
@jo-mueller
changed interfacial tension default value
71f5e4d
@jo-mueller
use dict as type for properties
21f0a84
@jo-mueller
rewrote _measure_properties to work without inputs
aeeed93
@jo-mueller
used ellipsoid expander to calculate min/max curvatures and anisotropies
827a62d
@jo-mueller
Merge remote-tracking branch 'upstream/main' into rewrite-spherical-h…
0398a49 
…armonics-as-class
@jo-mueller
moved expansion application functions to separate file
09f8105
@jo-mueller
Merge remote-tracking branch 'origin/use-expander-in-curvature-calcul…
1ab3e3e 
…ation' into rewrite-spherical-harmonics-as-class
@jo-mueller
Merge branch 'use-abc-for-expansion' into rewrite-spherical-harmonics…
e9c6ec3 
…-as-class
@jo-mueller
avoided storing data inside EllipsoidExpander
f2b04a8
@jo-mueller
put max/min curvature calculation in separate function
97e8fc4
@jo-mueller
put max/min curvature calculation in separate function
4698142
@jo-mueller
split porperty calculation in subfunctions called by parent class abs…
c0087b9 
…tract method
@jo-mueller
added docstring
f96b1e5
@jo-mueller
moved power spectrum calculation down to private function
1082570
@jo-mueller
removed get_measurements option
4e01e67
@jo-mueller
code style
e4e4953
@jo-mueller
stored expansion properties properly (features, metadata) in viewer l…
38bb05b 
…ayer
@jo-mueller
added more docstring
9749a33
@jo-mueller
split power spectrum calculation in separate function (individual coe…
46bb879 
…ffs and aggregator)
@jo-mueller
code style
50845df
@jo-mueller
Reran notebook
8f8f4ec
@jo-mueller
used Expanders in toolbox where applicble
a9fec49
@jo-mueller
used auto-derived anisotropy rather than specific function
f24af75
@jo-mueller
Merge remote-tracking branch 'upstream/main' into rewrite-spherical-h…
39e8506 
…armonics-as-class
@jo-mueller jo-mueller added the enhancement New feature or request label Jul 10, 2024
pre-commit-ci bot and others added 21 commits July 10, 2024 16:02
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
e5c1f68 
for more information, see https://pre-commit.ci
@jo-mueller
explictly passed gamma value as argument and removed __main__ in test
aef1c11
@jo-mueller
Merge branch 'rewrite-spherical-harmonics-as-class' of https://github…
6a3ac75 
….com/jo-mueller/napari-stress into rewrite-spherical-harmonics-as-class
@jo-mueller
added coefficients_ property to expansion class
f30c348
@jo-mueller
added check whether a None value has been passed (relevant during init)
9a9af55
@jo-mueller
added test
cb5ebc3
@jo-mueller
added macos to tested OS
5b96aae
@jo-mueller
Revert "added macos to tested OS"
0730418 
This reverts commit 5b96aae.
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
46f11d3 
for more information, see https://pre-commit.ci
@jo-mueller
fixed bug in coefficients property
45bb8f9
@jo-mueller
Merge branch 'rewrite-spherical-harmonics-as-class' of https://github…
5afd9bf 
….com/jo-mueller/napari-stress into rewrite-spherical-harmonics-as-class
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
65b994b 
for more information, see https://pre-commit.ci
@jo-mueller
Turned expander.coefficients_ into property and use `expander._coef…
7eb36d9 
…ficients` internally
@jo-mueller
Merge branch 'rewrite-spherical-harmonics-as-class' of https://github…
7e5542b 
….com/jo-mueller/napari-stress into rewrite-spherical-harmonics-as-class
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
a42fc19 
for more information, see https://pre-commit.ci
@jo-mueller
fixed getting properties from properties attribute
0fd13c8
@jo-mueller
Merge branch 'rewrite-spherical-harmonics-as-class' of https://github…
19dc6e0 
….com/jo-mueller/napari-stress into rewrite-spherical-harmonics-as-class
@jo-mueller
Added docstrings
78cea91
@jo-mueller
added docstrings
62f7c22
@jo-mueller
turned attribute properties into @property
c2a6c45
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
06ace0f 
for more information, see https://pre-commit.ci
@jo-mueller jo-mueller merged commit 674ed94 into campaslab:main Jul 12, 2024
5 of 6 checks passed
@jo-mueller jo-mueller deleted the rewrite-spherical-harmonics-as-class branch July 12, 2024 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jo-mueller