CSS-6377 add Superset Rock #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AmberCharitos
requested review from
gtato,
mertalpt,
kelkawi-a and
maabujayyab
mertalpt
approved these changes
Nov 27, 2023
maabujayyab
suggested changes
Nov 28, 2023
gtato
reviewed
Nov 28, 2023
licenses/LICENSE-rock
Outdated
There was a problem hiding this comment.
I am a bit confused by the license structure of these rocks. I see Kafka for example has a license "per component", even though sometimes it is difficult to define what a component is... Would you need licences for superset in here?
There was a problem hiding this comment.
From all of the Kubeflow ones I've see it seems the license is per reop - sometimes with multiple rocks as a bundle. I'm not sure what you mean by superset license?
gtato
approved these changes
Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR creates a Superset Rock from the apache upstream 2.1.0 tar.
Includes: