Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CSS-6377 add Superset Rock #2
CSS-6377 add Superset Rock #2
Changes from 19 commits
3174f6f
73cb77f
6aa01ca
00b3ba8
5c1a863
1079789
b3987db
92ab3c3
2d96567
bee8084
d0005af
9a7aa81
a6be440
3cdba5d
63d41b5
c2ae85c
38e8119
1dbb534
b4f79c7
7b180cb
fda8aaf
db634b9
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am a bit confused by the license structure of these rocks. I see Kafka for example has a license "per component", even though sometimes it is difficult to define what a component is... Would you need licences for superset in here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From all of the Kubeflow ones I've see it seems the license is per reop - sometimes with multiple rocks as a bundle. I'm not sure what you mean by superset license?