ci: use get_charms_build_with_cache.yaml workflow and use charm artefacts for individual tests #645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* ci: use get_charms_build_with_cache.yaml workflow This workflow enables the usage of canonical/charmed-kubeflow-workflows/.github/workflows/get_charms_build_with_cache.yaml for this CI, meaning that the integration tests and publish jobs are now able to download charm artefacts and use them consistently throught the various operations of this CI. Fixes #641
* ci, tests: pass charm artefacts to deploy and test charms This commit enables the "--charm-path" option to pass .charm artefacts to be deployed and tested at an individual level. This change enables the option to pass pre-built charms to the tests to avoid building them on the same test. It also ensures compatibility with the build_charm.py reusable workflow (from canonical/data-platform-workflows). Fixes: #639
DnPlas
changed the title
NohaIhab
reviewed
Jan 13, 2025
This was referenced Jan 15, 2025
…ation (#648) * use python plugin and add licenses to charms * use charmcraft channel 3.x/edge * use branch for quality checks workflow with charmcraft 3.x/edge * update charmcraft channel to latest/candidate
…ows (#651) * ci: remove wrapper around get charm paths and build with cache workflows This commit removes the extra abstraction of the get-charm-paths action and build_charm.yaml reusable workflow to avoid potential incompatibilities and sync issues with the data platforms workflows. * update workflows for dpw v29 * fix: use correct artifact name * nit: address comments for consistency with data repos --------- Co-authored-by: NohaIhab <[email protected]>
Use single (cached) build for integration tests & release Fix hardcoded path for `platforms` syntax remove workflow dispatch from release.yaml not needed add description for outputs rename get charm paths job and channel output pin quality checks back to main due to merging canonical/charmed-kubeflow-workflows#95 Use stage instead of prime in charmcraft files part (#658) Co-authored-by: Daniela Plascencia <[email protected]>
* init: pass cached charms to v1 bundle tests * add build dependency for bundle tests * add step to download packed charms * fix: wait-for units instead of applications (#659) * remove no_build option and refactor v1 tests * update v2 bundle tests * implement helper function to update context + comments * fix: update logs action (#663) Ref canonical/kubeflow-ci#152 * fix: modify ci.yaml release job to need get-charm-paths-channel * update tests README --------- Co-authored-by: Orfeas Kourkakis <[email protected]>
Co-authored-by: Carl Csaposs <[email protected]>
|
closed in favor of #665 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR merges
KF-6684-refactor-ci-with-buildbranch intomain. These are the changes:This workflow enables the usage of canonical/charmed-kubeflow-workflows/.github/workflows/get_charms_build_with_cache.yaml for this CI, meaning that the integration tests and publish jobs are now able to download charm artefacts and use them consistently throught the various operations of this CI.
Fixes #641
This commit enables the "--charm-path" option to pass .charm artefacts
to be deployed and tested at an individual level.
This change enables the option to pass pre-built charms to the tests
to avoid building them on the same test. It also ensures compatibility
with the build_charm.py reusable workflow (from canonical/data-platform-workflows).
Fixes: #639