-
Notifications
You must be signed in to change notification settings - Fork 794
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Menu buttons accessibility tab doc update #4240
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good Alina! Just a couple things:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🎉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! looks unrelated to this PR, but when clicking on the "Github link" in the accessibility table: https://carbondesignsystem-git-fork-alina-j-cf81ce-carbon-design-system.vercel.app/components/menu-buttons/accessibility#accessibility-testing-statusobject-objectobject-object it brings you to a "page not found". Looks like a mismatch between "MenuButtons" and "MenuButton"
Yes you're right, even this link is incorrect, it should direct to Menu button instead of Menu buttons, singular plural error. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am going to approve.
The image with the line issue has been fixed in the file added to this PR but not showing up in the preview. Sometimes that happens, and it should be fixed when it gets pushed live.
Hi @alina-jacob! Although the PR is closed, I wanted to confirm one minor detail related to the Menu buttons' Accessibility tab. I noticed a small inconsistency, and I thought I’d check with you here. Do you think it's fine to leave it as is, or should we address it in another PR for consistency's sake? |
Closes #3797
Closes #4251
MENU
New
Changed
TOGGLE
Changed