Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Menu buttons accessibility tab doc update #4240

Merged
merged 10 commits into from
Sep 13, 2024

Conversation

alina-jacob
Copy link
Member

@alina-jacob alina-jacob commented Sep 5, 2024

Closes #3797
Closes #4251

MENU

New

  • [Accessibility Tab] Added content and images for Menu and Combo button (Keyboard interactions, Design recommendations and Development considerations).

Changed

  • [Accessibility Tab] Updated content and images for Overflow menu (Keyboard interactions, Design recommendations).
  • [Usage tab] Updated label for the Anatomy image.
  • [Usage tab] 2 Combo button images updated to show "Primary action" as the button title instead of "Actions"
  • [Style tab] 2 Combo button images updated to show "Primary action" as the button title instead of "Actions"

TOGGLE

Changed

  • [Usage tab] Minor update that was mentioned here.

Copy link

vercel bot commented Sep 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
carbondesignsystem ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 13, 2024 11:26am

Copy link
Member

@laurenmrice laurenmrice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good Alina! Just a couple things:

Copy link
Member

@laurenmrice laurenmrice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2024-09-10 at 2 48 03 PM

This label in the tooltip looks visually low in the container. It needs to be adjusted so that it looks center.

Copy link
Member

@tay1orjones tay1orjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎉

Copy link
Member

@ariellalgilmore ariellalgilmore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! looks unrelated to this PR, but when clicking on the "Github link" in the accessibility table: https://carbondesignsystem-git-fork-alina-j-cf81ce-carbon-design-system.vercel.app/components/menu-buttons/accessibility#accessibility-testing-statusobject-objectobject-object it brings you to a "page not found". Looks like a mismatch between "MenuButtons" and "MenuButton"

@alina-jacob
Copy link
Member Author

LGTM! looks unrelated to this PR, but when clicking on the "Github link" in the accessibility table: https://carbondesignsystem-git-fork-alina-j-cf81ce-carbon-design-system.vercel.app/components/menu-buttons/accessibility#accessibility-testing-statusobject-objectobject-object it brings you to a "page not found". Looks like a mismatch between "MenuButtons" and "MenuButton"

Yes you're right, even this link is incorrect, it should direct to Menu button instead of Menu buttons, singular plural error.
I'll create an issue to fix that, thanks Ari @ariellalgilmore!

image

Copy link
Member

@laurenmrice laurenmrice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am going to approve.

The image with the line issue has been fixed in the file added to this PR but not showing up in the preview. Sometimes that happens, and it should be fixed when it gets pushed live.

@alina-jacob alina-jacob merged commit e53e94c into carbon-design-system:main Sep 13, 2024
7 checks passed
@Kritvi-bhatia17
Copy link
Contributor

Hi @alina-jacob! Although the PR is closed, I wanted to confirm one minor detail related to the Menu buttons' Accessibility tab. I noticed a small inconsistency, and I thought I’d check with you here. Do you think it's fine to leave it as is, or should we address it in another PR for consistency's sake?

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
8 participants