#101 Add voucher execution #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… CartesiDApp ABI for code generation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Closed
9 tasks
brunomenezes
requested changes
Mar 6, 2024
… before displaying a notification
brunomenezes
approved these changes
Mar 7, 2024
There was a problem hiding this comment.
@nevendyulgerov, it looks good to me. I have a mixed feeling regarding the <VoucherExecution/> being located in the apps/web instead of being part of the packages/ui. But that is not a merge blocker. Let's discuss this later.
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added the voucher execution logic in a component called
VoucherExecutionlocated inapps/web. For testing of this logic I used the following dapp which comes will functionality for adding inputs with vouchers.