Update wasm lanes and opcode costs #5022
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpapierski
requested review from
zajko,
darthsiroftardis,
EdHastingsCasperAssociation and
igor-casper
EdHastingsCasperAssociation
approved these changes
Dec 12, 2024
igor-casper
approved these changes
Dec 13, 2024
|
bors r+ |
|
Merge conflict. |
Conflicts: execution_engine_testing/tests/src/test/explorer/faucet.rs
zajko
reviewed
Dec 16, 2024
| @@ -850,7 +854,8 @@ mod tests { | |||
| let mut rng = TestRng::new(); | |||
| run_test_case(TOO_MANY_STANDARD, &mut rng); | |||
| run_test_case(FULL_STANDARD, &mut rng); | |||
| run_test_case(LESS_THAN_MAX_STANDARD, &mut rng); | |||
| // NOTE: current prod chainspec has a limit of 1 large transaction, so one less is 0 which | |||
There was a problem hiding this comment.
we use the prod chainspec in tests? I thought we use local? Could we have different limitations in local env? That would allow this test to be still valid?
There was a problem hiding this comment.
Historically we were always keeping local and prod chainspec consistent
zajko
approved these changes
Dec 16, 2024
|
bors r+ |
|
Build succeeded: |
casperlabs-bors-ng
bot
merged commit 1de16a7
into
casper-network:feat-2.0
3 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates lanes, and max gas per block to accommodate more native transfers equal to the amount available under 1.5.x.
As for Wasm lanes, there's ongoing work to update the matching algorithm to find a slot based on a payment amount. The effective limit will be the sum of costs from the Wasm lines (500CSPR). Here, updated Wasm lanes from this PR will be compatible with the new mechanism. Opcode cost multipliers are also scaled up to accommodate the new computational limit.