-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid writing extra devices when using IntanRecordingInterface
with multiple electrode groups
#1167
Conversation
IntanRecordingInterface
IntanRecordingInterface
with multiple electrode groups.
IntanRecordingInterface
with multiple electrode groups. IntanRecordingInterface
with multiple electrode groups
Co-authored-by: Szonja Weigl <[email protected]>
Also blocked by #1175: See the error here: |
All tests are passing now that we have merged #1175 @weiglszonja |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm, thanks!
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1167 +/- ##
==========================================
- Coverage 90.69% 90.07% -0.62%
==========================================
Files 129 129
Lines 8189 8285 +96
==========================================
+ Hits 7427 7463 +36
- Misses 762 822 +60
Flags with carried forward coverage won't be shown. Click here to find out more.
|
As in the title.
This is after #1164 as that laid the ground-work for this.
The problem is the last time I hardcoded that we only add the IntanDevice to the first group. The other groups have a default Device and that's where the extra ones come from.
I added a test and fixed this.