Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid writing extra devices when using IntanRecordingInterface with multiple electrode groups #1167

Merged
merged 15 commits into from
Jan 14, 2025

Conversation

h-mayorquin
Copy link
Collaborator

@h-mayorquin h-mayorquin commented Dec 19, 2024

As in the title.

This is after #1164 as that laid the ground-work for this.

The problem is the last time I hardcoded that we only add the IntanDevice to the first group. The other groups have a default Device and that's where the extra ones come from.

I added a test and fixed this.

@h-mayorquin h-mayorquin self-assigned this Dec 19, 2024
@h-mayorquin h-mayorquin marked this pull request as ready for review December 19, 2024 16:56
@h-mayorquin h-mayorquin changed the title Avoid multiple devices when writing with multiple electrodes in IntanRecordingInterface Avoid writing extra devices when using IntanRecordingInterface with multiple electrode groups. Dec 19, 2024
@h-mayorquin h-mayorquin changed the title Avoid writing extra devices when using IntanRecordingInterface with multiple electrode groups. Avoid writing extra devices when using IntanRecordingInterface with multiple electrode groups Dec 19, 2024
CHANGELOG.md Outdated Show resolved Hide resolved
@h-mayorquin
Copy link
Collaborator Author

@h-mayorquin
Copy link
Collaborator Author

All tests are passing now that we have merged #1175 @weiglszonja

Copy link
Contributor

@weiglszonja weiglszonja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, thanks!

@h-mayorquin h-mayorquin enabled auto-merge (squash) January 14, 2025 19:03
@h-mayorquin h-mayorquin merged commit 935bf6a into main Jan 14, 2025
40 checks passed
@h-mayorquin h-mayorquin deleted the avoid_multiple_intan_devices branch January 14, 2025 21:58
Copy link

codecov bot commented Jan 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.07%. Comparing base (96dfdff) to head (41314de).
Report is 16 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1167      +/-   ##
==========================================
- Coverage   90.69%   90.07%   -0.62%     
==========================================
  Files         129      129              
  Lines        8189     8285      +96     
==========================================
+ Hits         7427     7463      +36     
- Misses        762      822      +60     
Flag Coverage Δ
unittests 90.07% <100.00%> (-0.62%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...datainterfaces/ecephys/intan/intandatainterface.py 100.00% <100.00%> (ø)

... and 17 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants