-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set ceiling for HDMF to avoid failures with the latest release #1175
Conversation
@@ -6,6 +6,13 @@ __pycache__/ | |||
# C extensions | |||
*.so | |||
|
|||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have been using uv on my mac and I would like to add uv to our gitignore.
This is in line with what github is doing now, see:
github/gitignore#4545
For the same change "upstream".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was failing to create the file for me on mac when using uv. I guess the problem is that uv uses a different base directory.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also tested this on a conda base installation on my linux system and it correctly moves the file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why was this failing? Could it not find the base_gin_test_config.json file when you were using uv?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't remember right now. Either source or destination was incorrect during the copy.
#1167 also needs this: |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1175 +/- ##
==========================================
+ Coverage 90.69% 90.75% +0.06%
==========================================
Files 129 129
Lines 8189 8286 +97
==========================================
+ Hits 7427 7520 +93
- Misses 762 766 +4
Flags with carried forward coverage won't be shown. Click here to find out more. |
Currently, there are tests failing due to chunking errors with the latest release of hdmf:
#1168
I am putting a ceiling on the version right now until we fix that. If I remember well this requires or would be helped by first fixing the PoseEstimation interfaces in other PRs.