Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove source validation from converters and interfaces #1168

Merged
merged 7 commits into from
Jan 14, 2025

Conversation

h-mayorquin
Copy link
Collaborator

Should fix #1166.

Also, this problem came again with the IBL collaboration (personal communication).

@h-mayorquin h-mayorquin self-assigned this Dec 19, 2024
@h-mayorquin h-mayorquin changed the title remove source validation Remove source validation from converters and interfaces Dec 19, 2024
@h-mayorquin h-mayorquin marked this pull request as ready for review December 20, 2024 19:03
@h-mayorquin h-mayorquin merged commit fe5bfb4 into main Jan 14, 2025
40 checks passed
@h-mayorquin h-mayorquin deleted the remove_json_source_validation branch January 14, 2025 18:37
Copy link

codecov bot commented Jan 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.07%. Comparing base (96dfdff) to head (45f64f9).
Report is 15 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1168      +/-   ##
==========================================
- Coverage   90.69%   90.07%   -0.62%     
==========================================
  Files         129      129              
  Lines        8189     8284      +95     
==========================================
+ Hits         7427     7462      +35     
- Misses        762      822      +60     
Flag Coverage Δ
unittests 90.07% <ø> (-0.62%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/neuroconv/basedatainterface.py 87.05% <ø> (-8.30%) ⬇️
src/neuroconv/nwbconverter.py 87.68% <ø> (-7.29%) ⬇️

... and 15 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove json schema validation from interfaces and converters
2 participants