fix: use shared infra github token for release please #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 1, 2024 09:42
jgadling
reviewed
Aug 1, 2024
.github/workflows/release-please.yml
Outdated
| runs-on: ubuntu-latest | ||
|
|
||
| release-please: | ||
| runs-on: [ARM64, self-hosted, Linux] |
There was a problem hiding this comment.
Any particular reason we're running this on ARM?
There was a problem hiding this comment.
I copied that from the action provided by central infra. Not sure what difference this would make.
There was a problem hiding this comment.
It just runs the action on our internal infrastructure (and using ARM nodes) instead of letting GitHub run it (by default on x86 nodes). Since this is a public-facing project I'd prefer to use the standard GitHub nodes as much as possible.
There was a problem hiding this comment.
ok! I'll revert that :)
jgadling
approved these changes
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can't trigger a second workflow from a first workflow that used the repo's
GITHUB_TOKEN(see here). Use central infra's tokens instead.