Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use shared infra github token for release please #92

Merged
merged 4 commits into from
Aug 1, 2024
Merged

fix: use shared infra github token for release please #92

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e560000
use shared infra github token
Aug 1, 2024
7ace84c
update action
Aug 1, 2024
1798135
use our specific release please settings
Aug 1, 2024
63b9b9d
update infra
Aug 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 21 additions & 15 deletions .github/workflows/release-please.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,22 +1,28 @@
name: Release Please

on:
push:
branches:
- main

concurrency:
group: ${{ github.workflow }}-${{ github.ref }}
cancel-in-progress: true
name: release-please
jobs:
release:
name: Run release-please
runs-on: ubuntu-latest

release-please:
runs-on: [ARM64, self-hosted, Linux]
steps:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any particular reason we're running this on ARM?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I copied that from the action provided by central infra. Not sure what difference this would make.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It just runs the action on our internal infrastructure (and using ARM nodes) instead of letting GitHub run it (by default on x86 nodes). Since this is a public-facing project I'd prefer to use the standard GitHub nodes as much as possible.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok! I'll revert that :)

- name: Checkout code
uses: actions/checkout@v4
# See https://docs.github.com/en/actions/security-guides/automatic-token-authentication#using-the-github_token-in-a-workflow
# For why we need to generate a token and not use the default
- name: Generate token
id: generate_token
uses: tibdex/github-app-token@v2
with:
app_id: ${{ secrets.CZI_RELEASE_PLEASE_APP_ID }}
private_key: ${{ secrets.CZI_RELEASE_PLEASE_PK }}

- name: Run release-please
uses: google-github-actions/release-please-action@v3
with:
release-type: python
token: ${{ secrets.GITHUB_TOKEN }}
bump-minor-pre-major: true
- name: release please
uses: googleapis/release-please-action@v4
id: release
with:
release-type: python
token: ${{ steps.generate_token.outputs.token }}
bump-minor-pre-major: true
Loading