Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the RemoteNode.load_configuration() docs #477

Merged

Conversation

erlend-aasland
Copy link
Contributor

Spell out how it works and link to PdoBase.read()

Moreover, add return annotation to make sure that's included in the
rendered docs.

Spell out how it works and link to PdoBase.read()

Moreover, add return annotation to make sure that's included in the
rendered docs.
@erlend-aasland
Copy link
Contributor Author

Shamelessly based off of #405 (comment), in a slightly more concise wording.

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.65%. Comparing base (5734f37) to head (3da568c).
Report is 1 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #477      +/-   ##
==========================================
+ Coverage   67.55%   67.65%   +0.09%     
==========================================
  Files          26       26              
  Lines        3101     3104       +3     
  Branches      521      521              
==========================================
+ Hits         2095     2100       +5     
+ Misses        864      862       -2     
  Partials      142      142              
Files Coverage Δ
canopen/node/remote.py 55.12% <100.00%> (ø)

... and 1 file with indirect coverage changes

@acolomb acolomb merged commit d141e13 into christiansandberg:master Jul 2, 2024
1 check passed
@erlend-aasland erlend-aasland deleted the doc/load-configuration branch July 2, 2024 11:20
@erlend-aasland
Copy link
Contributor Author

Thanks for the review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants