add fillDescriptions to several plugins used at HLT (5/N)

[mmusich]

PR description:

This PR is similar in spirit to #47017, #47045, #47079, #47107, #47136 and #47191. It adds fillDescriptions (and applies light modification to modernize the source code) to a few EDProducers used at HLT for both Run 3 and Phase 2.

• unfortunately due to the inheritance structure of the general utility classes in the CommonTools subsystem the changes needed to be extended to a lot of other modules that are not used at HLT (commit 083eb7b).

PR validation:

• addOnTests.py runs fine.
• hltPhase2UpgradeIntegrationTests runs fine.
• runTheMatrix.py -l limited runs fine.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

N/A

[cmsbuild]

cms-bot internal usage

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47224/43505

[mmusich]

@cmsbuild, please test

[Martin-Grunewald]

addOptional does not work with ConfDb...

[mmusich]

I think we established already, it does - when a default is provided.

[cmsbuild]

-1

Failed Tests: HeaderConsistency UnitTests RelVals
Size: This PR adds an extra 416KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-93ce1a/44107/summary.html
COMMIT: ab7a710
CMSSW: CMSSW_15_0_X_2025-01-30-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/47224/44107/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found 1 errors in the following unit tests:

---> test testRecoMETMETProducers had ERRORS

RelVals

• 17034.0

----- Begin Fatal Exception 31-Jan-2025 16:14:50 CET-----------------------
An exception of category 'Configuration' occurred while
   [0] Constructing the EventProcessor
   [1] Validating configuration of module: class=CaloMETProducer label='recoExoticaValidationCaloHT'
Exception Message:
Illegal parameter found in configuration.  The parameter is named:
 'jets'
You could be trying to use a parameter name that is not
allowed for this plugin or it could be misspelled.
----- End Fatal Exception -------------------------------------------------

• 16834.0

----- Begin Fatal Exception 31-Jan-2025 16:10:50 CET-----------------------
An exception of category 'Configuration' occurred while
   [0] Constructing the EventProcessor
   [1] Validating configuration of module: class=CaloMETProducer label='recoExoticaValidationCaloHT'
Exception Message:
Illegal parameter found in configuration.  The parameter is named:
 'jets'
You could be trying to use a parameter name that is not
allowed for this plugin or it could be misspelled.
----- End Fatal Exception -------------------------------------------------

[civanch]

+1

[mmusich]

@cms-sw/dqm-l2 @cms-sw/pdmv-l2 @cms-sw/xpog-l2 do you have any comment concerning this PR?

[antoniovagnerini]

+dqm

• spurious differences seen in TrackerPhase2OTL1Track (open issue Non-reproducibility in TrackerPhase2OTL1Track #47071)
• spurious differences seen from unstable Run 3 WF *.7 (open issue spurious differences in outputs of Run-3 wfs *.7 #39803 )

[hqucms]

+1

[mmusich]

+hlt

• technical, no regressions expected.

[AdrianoDee]

+pdmv

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @rappoccio, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

[mandrenguyen]

+1