Feat/#9 닉네임 중복 체크 기능 구현 #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1o18z
commented
Oct 25, 2023
Comment on lines
76
to
+106
|
|
||
| public void checkDuplicatedNickname(String nickname) { | ||
| if (userRepository.findUserByProfileNickname(nickname).isPresent()) { | ||
| throw new IllegalArgumentException("이미 존재하는 닉네임입니다."); | ||
| } | ||
| } | ||
|
|
||
| public void checkDuplicatedUser(OAuthInfoResponse response) { | ||
| if (userRepository.existsUserByOauthInfo_oauthProviderAndOauthInfo_oauthProviderId( | ||
| response.oAuthProvider(), response.oAuthProviderId())) { | ||
| throw new IllegalArgumentException(ALREADY_REGISTERED_MESSAGE); | ||
| } | ||
| } |
There was a problem hiding this comment.
AuthService에 책임이 너무 많고 유저 중복 체크와 닉네임 중복 체크 로직은 UserService에 위치하는게 더 적절할 것 같아 AuthService에서 UserService로 이동했습니다!
추후에 AuthService의 역할을 OAuthService처럼 분리하여 개선할 예정입니다! 🙇🏻♀️🙆🏻♀️
yumyeonghan
requested changes
Oct 25, 2023
Comment on lines
52
to
65
| @GetMapping("/duplicate") | ||
| public ResponseEntity<Void> checkDuplicatedNickname(@RequestParam String nickname) { | ||
| userService.checkDuplicatedNickname(nickname); | ||
| return ResponseEntity.ok().build(); |
There was a problem hiding this comment.
dto 로 뺴서 @Valid 적용해주세용!
| @@ -20,6 +21,7 @@ | |||
| public class UserService { | |||
|
|
|||
| public static final String EXISTED_COMPANY_EMAIL_ERROR = "이미 사용 중인 회사이메일입니다."; | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
이슈번호
close: #9
작업 내용 설명
리뷰어에게 한마디
브랜치를 38 -> 9 변경하면서 꼬이게 되어 기존 PR을 닫고 새로 올렸습니다!
코멘트로 남겨주신 리뷰 반영하여 함께 푸시했습니다.