-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/#9 닉네임 중복 체크 기능 구현 #43
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
b186c14
refactor: 반환값이 없을 시 200(OK)를 반환하도록 변경
1o18z 692e1d1
feat: 닉네임 중복 검사 기능 구현
1o18z 827f8bb
refactor: 관심사 생성 메서드명 수정
1o18z f9e0ff2
refactor: 기본 이미지 URL을 상수로 분리
1o18z 59f6c41
refactor: AuthService의 닉네임, 유저 중복 검사 로직을 UserService로 이동
1o18z 785a348
refactor: 접근제어자 수정
4b3b61e
refactor: 코드 포멧팅
c8ae9f6
refactor: 코드 포멧팅
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AuthService에 책임이 너무 많고 유저 중복 체크와 닉네임 중복 체크 로직은 UserService에 위치하는게 더 적절할 것 같아 AuthService에서 UserService로 이동했습니다!
추후에 AuthService의 역할을 OAuthService처럼 분리하여 개선할 예정입니다! 🙇🏻♀️🙆🏻♀️