camerad: optimize calculate_exposure_value with improved loop performance #34633
+12
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deanlee
force-pushed
the
camerad_improve_calculate_exposure_value
branch
3 times, most recently
from
7ff7c03 to
ae94aca
Compare
deanlee
force-pushed
the
camerad_improve_calculate_exposure_value
branch
from
ae94aca to
99e3e3c
Compare
deanlee
force-pushed
the
camerad_improve_calculate_exposure_value
branch
from
99e3e3c to
15eca7a
Compare
deanlee
force-pushed
the
camerad_improve_calculate_exposure_value
branch
from
15eca7a to
a17ed25
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
improves the performance of the
calculate_exposure_valuefunction byrow_ptrin the inner loop to minimize memory access overhead.These changes reduce execution time by approximately 1ms per camera. If execution time remains a bottleneck, future optimizations could consider downsampling the ROI to further speed up the luminance calculation.