Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add hyperbole web-view #7666

Merged
merged 1 commit into from
Feb 2, 2025
Merged

Conversation

seanhess
Copy link
Contributor

Checklist:

  • Meaningful commit message, eg add my-cool-package (please don't mention build-constraints.yml)
  • At least 30 minutes have passed since uploading to Hackage
  • If applicable, required system libraries are added to 02-apt-get-install.sh or 03-custom-install.sh
  • (recommended) Package have been verified to work with the latest nightly snapshot, e.g by running the verify-package script
  • (optional) Package is compatible with the latest version of all dependencies (Run cabal update && cabal outdated)

The script runs virtually the following commands in a clean directory:

  stack unpack $package-$version # `-$version` is optional
  cd $package-$version
  rm -f stack.yaml && stack init --resolver nightly --ignore-subdirs
  stack build --resolver nightly --haddock --test --bench --no-run-benchmarks

@seanhess
Copy link
Contributor Author

It looks like test dependencies are also required to be on stackage for this to work?

I assume the procedure is to ask the owner of skeletest to add his package?

@alaendle
Copy link
Member

alaendle commented Feb 1, 2025

Diff-1.0.2 (changelog) (Grandfathered dependencies) is out of bounds for:

Could you allow a newer Diff so that we can execute the test-suite during build?

@alaendle alaendle merged commit 10428b9 into commercialhaskell:master Feb 2, 2025
1 check failed
@alaendle
Copy link
Member

alaendle commented Feb 2, 2025

Will include it to stackage and disable tests for web-view.

alaendle added a commit that referenced this pull request Feb 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants