Adjust component prop metadata labels #5569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#12260 Bundle Size — 62.48MiB (~+0.01%).
Warning Bundle contains 58 duplicate packages – View duplicate packages Bundle metrics
|
| Current #12260 |
Baseline #12256 |
|
|---|---|---|
 Initial JS |
45.56MiB(~+0.01%) |
45.56MiB |
 Initial CSS |
0B |
0B |
 Cache Invalidation |
21.08% |
21.06% |
| Chunks |
31 |
31 |
| Assets |
34 |
34 |
| Modules |
4377 |
4377 |
| Duplicate Modules |
504 |
504 |
| Duplicate Code |
30.81% |
30.81% |
| Packages |
468 |
468 |
| Duplicate Packages |
58 |
58 |
Bundle size by type 2 changes 1 regression 
1 improvement
| Current #12260 |
Baseline #12256 |
|
|---|---|---|
| JS |
62.47MiB (~+0.01%) |
62.47MiB |
| HTML |
10.94KiB (-0.34%) |
10.98KiB |
Bundle analysis report Branch fix/adjust-prop-metadata-labels Project dashboard
|
Performance test results: |
| ? colorTheme.dynamicBlue.value | ||
| : undefined, | ||
| cursor: isHovered ? 'pointer' : 'default', |
There was a problem hiding this comment.
I think this can just remain 'pointer' as this field only has effect when the mouse hovers
There was a problem hiding this comment.
pfft yeah, my brain stopped functioning here
balazsbajorics
approved these changes
May 5, 2024
seanparsons
approved these changes
May 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #5560
This PR adjusts the coloring of prop metadata labels in the inspector's component section so that:
Screen.Recording.2024-05-05.at.5.39.42.PM.mov
Manual Tests:
I hereby swear that: