Keep span when reordering grid items #6642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#15140 Bundle Size — 58.08MiB (~+0.01%).092c1fe(current) vs d1d46c1 master#15133(baseline) Warning Bundle contains 70 duplicate packages – View duplicate packages Bundle metrics
|
| Current #15140 |
Baseline #15133 |
|
|---|---|---|
 Initial JS |
41.05MiB(~+0.01%) |
41.05MiB |
 Initial CSS |
0B |
0B |
 Cache Invalidation |
18.13% |
18.54% |
| Chunks |
20 |
20 |
| Assets |
22 |
22 |
| Modules |
4169 |
4169 |
| Duplicate Modules |
213 |
213 |
| Duplicate Code |
27.3% |
27.3% |
| Packages |
477 |
477 |
| Duplicate Packages |
70 |
70 |
Bundle size by type 2 changes 1 regression 
1 improvement
| Current #15140 |
Baseline #15133 |
|
|---|---|---|
| JS |
58.07MiB (~+0.01%) |
58.07MiB |
| HTML |
7.37KiB (-0.25%) |
7.39KiB |
Bundle analysis report Branch feat/grid-span-reorder Project dashboard
Generated by RelativeCI Documentation Report issue
seanparsons
approved these changes
Nov 14, 2024
| const height = gridConfig?.originalCellBounds.height ?? 1 | ||
|
|
||
| let propsToUpdate: PropertyToUpdate[] = [] | ||
| propsToUpdate.push(propertyToDelete(PP.create('style', 'gridColumnStart'))) |
There was a problem hiding this comment.
where are these mutations coming from? 🙂 I think we usually do an array literal with spreads and ternaries to achieve conditional elements
There was a problem hiding this comment.
they come from what I thought was better readability, but no problem, updated in 092c1fe (#6642)
balazsbajorics
approved these changes
Nov 14, 2024
seanparsons
pushed a commit
that referenced
this pull request
Nov 18, 2024
**Problem:** Spans (or otherwise 1+ sized elements) are not preserved when using `gridReorderStrategy`. **Fix:** When running the reorder strategy, instead of nuking all positioning props only nuke the ones which are not used and, for elements that occupy multiple cells, set the respective width or height using the `span` syntax on the correct shorthand. I also took this chance to move the reorder tests to their own file (and added the new tests there). Fixes #6641
liady
pushed a commit
that referenced
this pull request
Dec 13, 2024
**Problem:** Spans (or otherwise 1+ sized elements) are not preserved when using `gridReorderStrategy`. **Fix:** When running the reorder strategy, instead of nuking all positioning props only nuke the ones which are not used and, for elements that occupy multiple cells, set the respective width or height using the `span` syntax on the correct shorthand. I also took this chance to move the reorder tests to their own file (and added the new tests there). Fixes #6641
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
Spans (or otherwise 1+ sized elements) are not preserved when using
gridReorderStrategy.Fix:
When running the reorder strategy, instead of nuking all positioning props only nuke the ones which are not used and, for elements that occupy multiple cells, set the respective width or height using the
spansyntax on the correct shorthand.I also took this chance to move the reorder tests to their own file (and added the new tests there).
Fixes #6641