-
-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add "gepetto-viewer" recipe #12850
Add "gepetto-viewer" recipe #12850
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@conda-forge-admin, please restart ci |
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/gepetto-viewer:
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@conda-forge/help-c-cpp After the decision to focus on gepetto-viewer only in this recipe and after some work done on the X11 and OpenGL dependencies I finally managed to converge to a simple recipe that succeed to build Linux package. However, after trying few workarounds, I cant manage to get it done for osx. I got the error:
during compilation. From what I found, the most similar error was in recipe discussion: conda-forge/ambertools-feedstock#18 which was also about a gui on MacOs. It seems related to the issue conda-forge/tk-feedstock#15 about interference between I am not familiar with those kind of issue and already tried different fixes. Could you please help and advice on this issue ? |
ping @jcarpent : update on recipe situation. Do you accept to also be a maintainer ? |
Fine to be considered as a maintener |
@conda-forge/help-c-cpp Workaround foundAfter digging on a MacOS VM the behaviour of tk and X11 and how they install conflict headers, and all the conda-forge threads about this interaction, the cleanest warkaround i found is to alias the X11 of root include (which is corrupt by the tk installation which is required) to let the compiler use the host include folder X11 which is not corrupted. I restore the aliasing after compilation to respect folder structure for conda-build. Next stepI think this PR is then ready to merge, @conda-forge/help-c-cpp |
@conda-forge/help-c-cpp could it be possible to review the PR ? Recipe looks finish, checklist is done and CI is ok. Thanks ! |
ab0f641
to
e8f7179
Compare
@conda-forge/help-c-cpp , I squashed and rebase the PR branch to make it more readable for review. |
@conda-forge/help-c-cpp We would need this package to be inside conda-forge before adding additional packages. Would you have time to review this PR and merge it? Justin |
@wolfv Sorry to directly ask you this, but we would need this PR to be merged, but we do not have any feedback from the maintainers. I guess they are all occupied, but if you have the rights, would you have time to handle this PR? |
@conda-forge-admin, please ping team |
Hi! This is the friendly automated conda-forge-webservice. I was asked to ping @conda-forge/staged-recipes and so here I am doing that. |
thanks for the contribution! |
@wolfv Thank you for the merge ! |
Thanks @wolfv for the quick merge. |
btw @ymontmarin not sure if you deliberately chose |
@wolfv you are right ! I change it on the feedstock. |
Checklist
url
) rather than a repo (e.g.git_url
) is used in your recipe (see here for more details)