Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CORE-18169: Replace two password change kafka payloads with one #1418

Merged
merged 2 commits into from
Dec 20, 2023
Merged

CORE-18169: Replace two password change kafka payloads with one #1418

merged 2 commits into from
Dec 20, 2023

Conversation

Tom-Fitzpatrick
Copy link
Contributor

@Tom-Fitzpatrick Tom-Fitzpatrick commented Dec 19, 2023 •
edited
Loading

This deletes:

  • net.corda.data.permissions.management.user.ChangeUserPasswordSelfRequest,
  • net.corda.data.permissions.management.user.ChangeUserPasswordOtherRequest

And replaces them with net.corda.data.permissions.management.user.ChangeUserPasswordRequest,

Corresponding runtime-os PR: corda/corda-runtime-os#5302

@corda-jenkins-ci02
Copy link
Contributor

Scanning for breaking API changes introduced by this PR

Scan Succeeded

@Tom-Fitzpatrick Tom-Fitzpatrick force-pushed the tomf/CORE-18169/simplify-password-change-messages branch from bba700c to 12b7289 Compare December 19, 2023 16:11
@corda-jenkins-ci02
Copy link
Contributor

corda-jenkins-ci02 bot commented Dec 19, 2023 •
edited
Loading

Jenkins build for PR 1418 build 5

Build Successful:
Jar artifact version produced by this PR: 5.2.0.21-alpha-1703075132231

@Tom-Fitzpatrick Tom-Fitzpatrick force-pushed the tomf/CORE-18169/simplify-password-change-messages branch from 721d40d to 3470962 Compare December 20, 2023 12:25
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@Tom-Fitzpatrick Tom-Fitzpatrick marked this pull request as ready for review December 20, 2023 14:17
@Tom-Fitzpatrick Tom-Fitzpatrick requested a review from a team as a code owner December 20, 2023 14:17
vkolomeyko
vkolomeyko approved these changes Dec 20, 2023
View reviewed changes
Copy link
Contributor

@vkolomeyko vkolomeyko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Tom-Fitzpatrick Tom-Fitzpatrick mentioned this pull request Dec 20, 2023
Merged
@Tom-Fitzpatrick Tom-Fitzpatrick requested a review from a team December 20, 2023 14:26
@Tom-Fitzpatrick Tom-Fitzpatrick merged commit 7d428e1 into release/os/5.2 Dec 20, 2023
3 checks passed
@Tom-Fitzpatrick Tom-Fitzpatrick deleted the tomf/CORE-18169/simplify-password-change-messages branch December 20, 2023 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vkolomeyko vkolomeyko vkolomeyko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Tom-Fitzpatrick @vkolomeyko