CORE-18169: Change User password - db worker changes #5302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Tom-Fitzpatrick
changed the title
Tom-Fitzpatrick
force-pushed
the
tomf/CORE-18169/change-password-db-worker-side
branch
from
017a0b2 to
8493993
Compare
Tom-Fitzpatrick
changed the title
Signed-off-by: TomFitzpatrick <[email protected]>
…wo avro message types with one Signed-off-by: TomFitzpatrick <[email protected]>
Signed-off-by: TomFitzpatrick <[email protected]>
Signed-off-by: TomFitzpatrick <[email protected]>
Signed-off-by: TomFitzpatrick <[email protected]>
Signed-off-by: TomFitzpatrick <[email protected]>
Tom-Fitzpatrick
force-pushed
the
tomf/CORE-18169/change-password-db-worker-side
branch
from
6ef05c3 to
678e4c8
Compare
|
Jenkins build for PR 5302 build 12 Build Successful: |
Tom-Fitzpatrick
commented
Dec 20, 2023
gradle.properties
Outdated
| @@ -44,7 +44,7 @@ commonsLangVersion = 3.12.0 | |||
| commonsTextVersion = 1.10.0 | |||
| # Corda API libs revision (change in 4th digit indicates a breaking change) | |||
| # Change to 5.2.0.xx-SNAPSHOT to pick up maven local published copy | |||
| cordaApiVersion=5.2.0.20-beta+ | |||
| cordaApiVersion=5.2.0.21-alpha-1703075132231 | |||
There was a problem hiding this comment.
I will update this to point to the beta, once the corresponding corda-api PR is merged
corda/corda-api#1418
vkolomeyko
reviewed
Dec 20, 2023
| val validator = EntityValidationUtil(entityManager) | ||
| val user = validator.validateAndGetUniqueUser(request.requestedBy) | ||
|
|
||
| println("old password hash: ${user.hashedPassword}") |
There was a problem hiding this comment.
Suggested change
| println("old password hash: ${user.hashedPassword}") | |
| log.debug { "old password hash: ${user.hashedPassword}" } |
There was a problem hiding this comment.
Ah thanks, I'll just remove this actually as it was left over from when I was debugging it
gradle.properties
Outdated
| @@ -44,7 +44,7 @@ commonsLangVersion = 3.12.0 | |||
| commonsTextVersion = 1.10.0 | |||
| # Corda API libs revision (change in 4th digit indicates a breaking change) | |||
| # Change to 5.2.0.xx-SNAPSHOT to pick up maven local published copy | |||
| cordaApiVersion=5.2.0.20-beta+ | |||
| cordaApiVersion=5.2.0.21-alpha-1703075132231 | |||
There was a problem hiding this comment.
- Will need to revert this change once
corda-apiPR is merged.
There was a problem hiding this comment.
Merged the corda-api PR and updated this config
Signed-off-by: TomFitzpatrick <[email protected]>
Signed-off-by: TomFitzpatrick <[email protected]>
Signed-off-by: TomFitzpatrick <[email protected]>
|
Tom-Fitzpatrick
deleted the
tomf/CORE-18169/change-password-db-worker-side
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the db-worker side of the User password change feature in
UserWriterImpl.ktBecause we can get the username from the request header, this also changes the endpoints:
{loginName}/otheruserpasswordto/otheruserpassword{loginName}/selfpasswordto/selfpasswordThis adds change password methods to ClusterBuilder to support future e2e tests.
Corda-api changes to support this: corda/corda-api#1418